Adjust d3 update to enable text mode animation #1011
Conversation
rreusser
force-pushed
the
fix-text-animation
branch
from
785d46b to
4f3f0a6
Compare
| .each(function(d) { | ||
|
|
||
| // This just *has* to be totally custom becuase of SVG text positioning :( | ||
| // It's obviously copied from translatePoint; we just can't use that |
There was a problem hiding this comment.
Edit: technically I think maybe translatePoint would work. I'm not 100% certain how much work it is to recompute the positions a bunch, but it seems silly to do that for every tspan.
There was a problem hiding this comment.
Ha. That's not too bad. Thanks for the comment!
|
For reference, the challenge here was to position multiline text (= tspans) correctly since the precise sequence of events here is a little tricky. The solution was to recompute the positions an extra time, which I don't like but which I think is unavoidable.
|
| .each(function(d) { | ||
|
|
||
| // This just *has* to be totally custom becuase of SVG text positioning :( | ||
| // It's obviously copied from translatePoint; we just can't use that |
There was a problem hiding this comment.
Ha. That's not too bad. Thanks for the comment!
|
💃 nicely done. |
|
Turned out to be reasonably straightforward after messing around with it for three hours… |
cc @etpinard @cpsievert
This PR refactors text mode scatter just slightly to properly duck-type the node being translated as a transition. The text node itself remains an instantaneous update.